Reviewed the Python Secure Coding Guide and made a lot of minor changes #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: myteron <[email protected]>
myteron
reviewed
Oct 21, 2025
docs/Secure-Coding-Guide-for-Python/CWE-682/CWE-1335/01/README.md
Outdated
Show resolved
Hide resolved
myteron
requested changes
Oct 21, 2025
Co-authored-by: myteron <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
s19110
reviewed
Oct 28, 2025
Comment on lines
90
to
99
| |Hardcoded `IPs` or ports|Rather than hardcoding IP addresses DNS should be properly implemented in the deployment in combination with solutions such as:| | ||
|
|
||
| * `RFC 9250` - [DNS over Dedicated QUIC Connections (ietf.org)](https://datatracker.ietf.org/doc/rfc9250/) | ||
| * `RFC 7858` - [Specification for DNS over Transport Layer Security (TLS) (ietf.org)](https://datatracker.ietf.org/doc/html/rfc7858) | ||
| * `RFC 6494` - [Certificate Profile and Certificate Management for SEcure Neighbor Discovery (SEND) (ietf.org) for IPV6](https://datatracker.ietf.org/doc/rfc6494/) | ||
| * `DNSSEC` [RFC 9364](https://datatracker.ietf.org/doc/html/rfc9364), `RFC 6014`, `5155`, `4641`.... | ||
|
|
||
| The order and ways to resolve IPs is configured via `/etc/nsswitch.conf` on most Unix systems. | ||
|
|
||
| Using `mTLS` with a high granularity of machine identities can reduce or remove `DNS` related risks. |
There was a problem hiding this comment.
The bullet points are now outside of the table. I think using <br> is fine in this case.
There was a problem hiding this comment.
Yes I agree but unfortunately same thing with the linter happens:
MD033/no-inline-html: Inline HTML [Element: table]markdownlintMD033
Which made me think that this was the best solution for it... maybe we should discuss this.
Removed talking about STRIDE, added more information about Oracle Access Management including a reference Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
myteron
approved these changes
Oct 30, 2025
myteron
approved these changes
Oct 30, 2025
s19110
approved these changes
Oct 31, 2025
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
Signed-off-by: Bartlomiej Karas <[email protected]>
s19110
suggested changes
Oct 31, 2025
Comment on lines
243
to
244
| |[SEI CERT JAVA 2024]|NUM01-J. Do not perform bitwise and arithmetic operations on the same data [online]. Available from: [https://wiki.sei.cmu.edu/confluence/display/java/NUM01-J.+Do+not+perform+bitwise+and+arithmetic+operations+on+the+same+data](https://wiki.sei.cmu.edu/confluence/display/java/NUM01-J.+Do+not+perform+bitwise+and+arithmetic+operations+on+the+same+data), [Accessed 6 May 2025]| | ||
| |[SEI CERT C 2025]|CERT C Coding Standard [online]. Available from: [https://www.securecoding.cert.org/confluence/display/seccode/CERT+C+Coding+Standard](https://www.securecoding.cert.org/confluence/display/seccode/CERT+C+Coding+Standard) [Accessed 6 May 2025]| |
There was a problem hiding this comment.
These lines need to be removed because now they are duplicates of the table rows.
Signed-off-by: Bartlomiej Karas <[email protected]>
s19110
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few sentences, moved things around, fixed typos, removed Wikipedia links and inserted new links etc.