Skip to content

pySCG pillar 664 base 409 #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2025
Merged

pySCG pillar 664 base 409 #944

merged 7 commits into from
Jul 24, 2025

Conversation

myteron
Copy link
Contributor

@myteron myteron commented Jul 15, 2025

Signed-off-by: Helge Wehder <[email protected]>
@s19110
Copy link
Contributor

s19110 commented Jul 17, 2025

reviewing

Copy link
Contributor

@s19110 s19110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments and suggestions.

Comment on lines 14 to 15
class ZipExtractException(Exception):
"""Custom Exception"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we use the built-in ValueError instead of creating a custom exception with no distinct characteristics?

@dwiley258
Copy link
Contributor

+1 from me

@myteron myteron merged commit c8e13db into ossf:main Jul 24, 2025
2 checks passed
@myteron myteron deleted the pySCG-664-409 branch July 24, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants