-
Notifications
You must be signed in to change notification settings - Fork 172
pySCG pillar 664 base 409 #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
myteron
commented
Jul 15, 2025
- Adding doc for CWE409 as part of pySCG: Doc2GitHub, moving code from an internal confluence to this GitHub space. #531
- Updated TEMPLATE_README.md with html table tags
Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments and suggestions.
docs/Secure-Coding-Guide-for-Python/templates/README_TEMPLATE.md
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-703/CWE-476/compliant03.py
Outdated
Show resolved
Hide resolved
class ZipExtractException(Exception): | ||
"""Custom Exception""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we use the built-in ValueError instead of creating a custom exception with no distinct characteristics?
docs/Secure-Coding-Guide-for-Python/CWE-664/CWE-409/compliant01.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Helge Wehder <[email protected]>
…ith suggested changes Signed-off-by: Helge Wehder <[email protected]>
+1 from me |