FFmpeg WHIP: Add NACK & RTX support(depends other patches) #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch is still generated by git config author.
refer to https://www.ffmpeg.org/developer.html#Submitting-patches-1 add header "X-Unsent: 1" add email recipients Signed-off-by: Jack Lau <[email protected]>
All files in the .github directory pertain to CI/CD and should be ignored; they should not be included in the patch.
This PR refer to ossrs#39 and ossrs#38 --------- Signed-off-by: Jack Lau <[email protected]>
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau <[email protected]>
Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options descriptions Signed-off-by: Jack Lau <[email protected]>
AVCodecParameters::profile only contains constraint_set1_flag (AV_PROFILE_H264_CONSTRAINED 1<<9). So add H264 constraints flag fully parse refer to hlsenc write_codec_attr Signed-off-by: Jack Lau <[email protected]>
See RFC5280 4.1.2.2 Co-authored-by: winlin <[email protected]> Signed-off-by: Jack Lau <[email protected]>
RTP retransmission described in RFC4588 (RTX) is an effective packet loss recovery technique for real-time applications with relaxed delay bounds. This patch provides a minimal implementation for RTX and RTCP NACK (RFC3940) and its associated SDP signaling and negotiation. Co-authored-by: Sergio Garcia Murillo <[email protected]> Signed-off-by: Jack Lau <[email protected]>
Signed-off-by: Jack Lau <[email protected]>
Signed-off-by: Jack Lau <[email protected]>
add rtx_history_size option Signed-off-by: Jack Lau <[email protected]>
JackLau1222
force-pushed
the
workflows
branch
2 times, most recently
from
1c20a98 to
487998b
Compare
JackLau1222
force-pushed
the
workflows
branch
2 times, most recently
from
2c40a5c to
80db6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NACK & RTX patch depends other patchs(like ignore_ipv6 patchset), so I place them all and submit this PR for showing the status of this patch