np.NaN -> np.nan (Error) #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dashirov wants to merge 1 commit into ourownstory:main from dashirov:main

dashirov commented Apr 1, 2025

np.NaN -> np.nan (Error)
view(dtype) -> astype(dtype) (Warning)

🔬 Background

Numpy obsoleted use of np.NaN in favor of np.nan
Pandas deprecated use of view() in favor of astype()

🔮 Key changes

Eliminated runtime errors and warnings by following dependency package maintainer's suggestions

📋 Review Checklist

I have performed a self-review of my own code.
I have commented my code, added docstrings and data types to function definitions.
I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.


          np.NaN -> np.nan (Error)

3abc101

view(dtype) -> astype(dtype) (Warning)

vreoo commented Jun 21, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet