fix: uiStatic release namespace as default
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Metaflow Helm chart is applied in a k8s cluster with a non-default release namespace and `.Values.namespace` is not set or does not match the release namespace value, the `metaflow-ui-static` service will be in a different namespace than its deployment. This means that the service will never have any endpoints associated with it. This commit removes the template syntax to set the namespace as `default` if `.Values.namespace` is not set. There is a larger discrepancy here in that the UI deployments are always in the release namespace, but their services may be in a different namespace. This commit only makes the templates consistent and does not address this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Metaflow Helm chart is applied in a k8s cluster with a non-default release namespace and
.Values.namespaceis not set or does not match the release namespace value, themetaflow-ui-staticservice will be in a different namespace than its deployment. This means that the service will never have any endpoints associated with it.This commit removes the template syntax to set the namespace as
defaultif.Values.namespaceis not set.There is a larger discrepancy here in that the UI deployments are always in the release namespace, but their services may be in a different namespace. This commit only makes the templates consistent and does not address this issue.