Fix airpods recording #783
Conversation
# Conflicts: # Telegram-Mac/Info.plist # TelegramShare/Info.plist
# Conflicts: # Telegram-Mac/Info.plist # TelegramShare/Info.plist
|
Mike Renoir seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dm3ch
force-pushed
the
fix-airpods-recording
branch
from
2765252 to
854ec94
Compare
|
@overtake Sorry for the mention, but maybe you can take a look at this PR. The problem with airpods is very annoying for me and some other users. |
|
i didn't notice this PR. Sorry. anyway. fixed. thanks. i fixed in the same way |
|
@overtake How to know when this will be released on the app store? It still does not work for me with the app store build. |
i will send to review today. i bet on weekends or next week. you also can switch to stable version macos.telegram.org. 9.3 coming today. |
|
Hi @overtake Do you happen to have any updates on this PR? The bug still occurs. |
overtake
force-pushed
the
master
branch
3 times, most recently
from
9aa8690 to
579cebb
Compare
6 participants
It's a very naive attempt to fix a bug with AirPods (24kHZ sample rate) recorded voice messages.
I just added "resampling" code similar to what it's already there for 16kHZ. Now in my self-built version of Telegram client, I haven't got a speedup of recording and voice pitch.
Actually, it would be better to write universal re-sampling code, but I'm pretty bad in audio and in swift to do it myself.
During the research I also found that in iOS client (https://github.com/TelegramMessenger/Telegram-iOS/blob/702f2547830ca406ce41081ea4170f24533f9a01/submodules/TelegramUI/Sources/ManagedAudioRecorder.swift ) there's pretty similar part of code for audio recording but it doesn't have transcoding and it works great with AirPods, actually I don't know why, but it's too much differences to easily port it to this project for me.
#112 #590 #692