-
-
Notifications
You must be signed in to change notification settings - Fork 722
docs(linter): Add configuration option docs for promise/no-callback-in-promise rule. #15176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(linter): Add configuration option docs for promise/no-callback-in-promise rule. #15176
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the no_callback_in_promise rule to rename the callbacks configuration field to exceptions and adds schema support for better configuration handling.
- Renamed the configuration field from
callbackstoexceptionswith clearer documentation - Added
JsonSchemaderive and serde attributes for proper schema generation - Updated all references to use the new
exceptionsfield name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Actually I think Copilot is right and I misunderstood the intent of the |
CodSpeed Performance ReportMerging #15176 will not alter performanceComparing Summary
Footnotes
|
…n-promise rule. Also rename the struct field name from `callbacks` to `exceptions`, as that's what is actually used in the code and is what's defined in the original ESLint rule.
And define "exceptions" explicitly in the struct.
074dd3f to
76039c5
Compare
Part of #14743.
Generated docs: