Skip to content

Draft: Return to mainline schemars crate #15205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Draft: Return to mainline schemars crate #15205

wants to merge 3 commits into from
+65 −64

Conversation

@connorshea
Copy link
Collaborator

@connorshea connorshea commented Nov 1, 2025

The migration docs could be better, but this gets us part of the way there.

Not sure if this is worth finishing as it removes some things that are relied on by crates/oxc_linter/src/config/plugins.rs.

@connorshea
Return to mainline schemars crate.
6579f4d 
Unfortunately they changed the API a good amount. These changes resolve MOST issues, but the remaining issues are beyond my understanding to solve.

See https://github.com/GREsau/schemars/blob/master/docs/0-migrating.md
@connorshea
Replace is_referenceable with inline_schema.
90bcaca 
Per the changelog for schemars:

`JsonSchema::is_referenceable()` has been removed, and replaced with the more clearly-named `JsonSchema::always_inline_schema()` (which should returns the **opposite** value to what `is_referenceable` returned!)

This was later renamed to just `inline_schema`.
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 1, 2025

CodSpeed Performance Report

Merging #15205 will not alter performance

Comparing connorshea:mainline-schemars (2b1cbeb) with main (1b9f6fc)1

Summary

✅ 33 untouched
⏩ 4 skipped2

Footnotes

  1. No successful run was found on main (c45a080) during the generation of this report, so 1b9f6fc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314 camc314 will be requested when the pull request is marked ready for review camc314 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@connorshea