Skip to content

Conversation

@hcsch
Copy link

@hcsch hcsch commented May 7, 2023

  • Use plural for enum describing a value descriptions statement
  • Use same spelling for value for a single value description
  • Use descriptive names for fields of a value description

I stumbled across the ValDescription type while using https://github.com/technocreatives/dbc-codegen, and was a bit confused by the fields being named a and b. I hope this commit can alleviate such confusion for others in the future.

This is a breaking change, so it'll likely have to wait for a future major release.

* Use plural for enum describing a value descriptions statement
* Use same spelling for value for a single value description
* Use descriptive names for fields of a value description
@nyurik
Copy link
Member

nyurik commented Nov 1, 2025

the a and b fields have been renamed in #45, released in v7.0.0. I am a bit uncertain if the churn required to rename enum ValueDescription to ValueDescriptions and struct ValDescription -> ValueDescription makes sense tbh... unless more folks chime in on this? Regardless, there is not much sense to keep this PR open as the code has diverged significantly - easier to rename in a new PR

@nyurik nyurik closed this Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants