image: enable basic tab completion for bash #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have a look at this! I think we could maybe do something with a small Rust program here to avoid all the bash logic. |
citrus-it
force-pushed
the
andy/completion
branch
from
9b5066f to
f6e823e
Compare
citrus-it
force-pushed
the
andy/completion
branch
from
f6e823e to
8260af5
Compare
|
I think we should merge the small fragment that is in this branch now to get into the next release, and we can circle back later with a better solution if there is one. |
|
With my apologies for the delay, I've pushed up what I came up with here: https://github.com/oxidecomputer/helios-bash-completion Can you try it to see if it works for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets basic tab completion working for bash builtins and for various illumos commands that take a zone name -- most usefully
zlogin.It also adds
oxlog's location to the PATH in the GZ, where it's most often used.