-
Notifications
You must be signed in to change notification settings - Fork 5
Exit from bestpath early if there's only 1 path to evaluate #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I am able to reproduce the "missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @taspelund
Signed-off-by: Trey Aspelund <[email protected]>
Signed-off-by: Trey Aspelund <[email protected]>
Signed-off-by: Trey Aspelund <[email protected]>
Signed-off-by: Trey Aspelund <[email protected]>
329c3f9
to
949450e
Compare
Pretty sure this latest CI failure is because I updated the init.sh scripts for debian/arista nodes in a4x2 but forgot to update it for arista/juniper in interop. Will submit a testbed PR to address it, which should let this pass. |
I think this is ready to merge once we have the interop tests passing. I re-ran
Not sure if this is a known thing, or maybe there's a lifetime to how long buildomat will retain artifacts from old jobs? |
Since there have been substantial updates to the machinery underpinning interop, i would run the whole build/test job combo again, or just push an empty commit to this PR to running all of CI fresh. |
No description provided.