Add a Rust binary to the switch zone to report the local switch ID #8985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be used for the switch zone shell prompt, which currently uses curl to talk to the local MGS. Having gateway-cli do it instead means that: 1) the program would automatically pick up new changes to the API 2) things would break at build-time if the API were broken 3) ls-apis would see this consumer Addresses oxidecomputer#8976 Signed-off-by: Andrii Sultanov <[email protected]>
… instead of curl Fixes oxidecomputer#8976 Signed-off-by: Andrii Sultanov <[email protected]>
|
Thanks! I'll give this a whirl on a test system to double check the packaging, but it might be a bit of a wait for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
local-switch-idcommand togateway-cli, package it into the switch zone, use it in the shell prompt instead ofcurl.I've tested the
gateway-clibinary itself with a mock server, but can't be too sure about the packaging - I've followed 4fa8e74 hereFixes #8976