Ci test run #31
Open
Ci test run #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport changes from master
Code is merged but tests are disabled and code if #defed out. Starting point for porting after major code changes.
pabuhler
force-pushed
the
ci-test-run
branch
6 times, most recently
from
8a950c8 to
1d4672d
Compare
Move cryptex code to separate functions so it can be reused. Due to support for non in-place io it is not always possible to modify the input buffer in the way the cryptex draft expected therefore use multiple encrypt / decrypt calls when io is not in-place. The gcm ciphers do not currently support multiple operations so non in-place io with csrc's is not supported.
pabuhler
force-pushed
the
ci-test-run
branch
2 times, most recently
from
7ed0ea9 to
276c7e0
Compare
pabuhler
force-pushed
the
ci-test-run
branch
from
91262c6 to
7ed0ea9
Compare
pabuhler
force-pushed
the
ci-test-run
branch
from
e9bc13e to
e26fe06
Compare
Add support for cryptex
Currently, it is silently assumed that we always have master key provided, even when the policy says we don't use encryption and authentication. This results in streams with such policy to fail. Fix that by properly calculating the expected master key length by taking in account authentication type too. Correctly set expected key length for null crypto policy to 0. Do not assume we have HMAC if the policy is set to not have. Add a test case for null/null policy while at it. Signed-off-by: Ivaylo Dimitrov <[email protected]>
Properly support null crypto and null auth scenario
Add ability to trigger manually
Add a new option CRYPTO_LIBRARY that replaces all the ENABLE_XXXX options. This makes it a little simpler and removes the possibility of configuring multiple backends. The name CRYPTO_LIBRARY is the same value currently used in the meson build. cisco#697
pabuhler
force-pushed
the
ci-test-run
branch
4 times, most recently
from
6aaafb2 to
e73c0fb
Compare
Add a new option --with-crypto-library that replaces all the --enabled-xxxx options. This makes it a little simpler and removes the possibility of configuring multiple backends. cisco#697
Change crypto config, use one option with a list of values
pabuhler
force-pushed
the
ci-test-run
branch
3 times, most recently
from
2305984 to
091df84
Compare
It is better to use an external and well proven crypto library as the default backend. The internal code should only be there as a fall back. This will also mean that GCM will be available by default. cisco#579
Change to use OpenSSL as default crypto library
The test vectors are generated based on RFC 6188 section 7.4 . It demonstrates that the kdf for AES 192 is currently broken. It mistakenly uses the kdf in AES 256 mode as described in cisco#763.
Set the kdf key length to be the determined input key length. This will set it correctly for AES ICM 128/192/256. In the case of AES GCM 128 & 256 it needs to be increased by 2 to match the corresponding AES ICM cipher. fixes cisco#763
Fix AES 192 kdf
libz & libdl are not direct dependencies of libsrtp, but my be required by the crypto library at runtime. Remove the dependency check form configure and rely on pkg_config to pull them in if needed. cisco#631
Do not explicitly check for runtime dependencies when building
pabuhler
force-pushed
the
ci-test-run
branch
2 times, most recently
from
6c932e8 to
fc71582
Compare
This does a release build and install on all platforms. Does both static and shared builds. Useful to verify what a release looks like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.