ci test run 2_x #32
Draft
ci test run 2_x #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srtp_get_session_keys, which is used by both srtp_unprotect_mki and srtp_unprotect_rtcp_mki, determines the tag len from rtp_auth. This fails when rtp_auth differ from rtcp_auth. E.g. when SRTP is used with weak authentication but SRTCP must not (RFC 3711). This commit splits the function in two: srtp_get_session_keys_rtp srtp_get_session_keys_rtcp And adds a short auth policy test to test/srtp_driver.
explicitly look for mbedcrypto dependency
…-auth Fix srtp_unprotect_rtcp_mki when RTP auth != RTCP
- The definition for the function has the signature: `srtp_err_status_t srtp_remove_stream(srtp_t session, uint32_t ssrc)` - This is not always same as the signature present in srtp.h: `srtp_err_status_t srtp_remove_stream(srtp_t session, unsigned int ssrc)` This causes function signature mismatch. Aligned the signature from `srtp.h` with the definition using `uint32_t`
Git hub is moving to ubuntu-latest on GitHub is moving to 24.04 and there re issues installing clang-format-12 . (cherry picked from commit 2a6c15d)
update formatting scripts to clang-format-14
update upload-artifact version in cifuzz task
…am_signature Fix function signature mismatch for `srtp_remove_stream`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.