refactor: #718 only drop TimestampSeries #1274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cmp0xff
changed the title
cmp0xff
commented
Jul 13, 2025
Comment on lines
+624
to
+643
| check( | ||
| assert_type(s5.dt.as_unit("s"), "pd.Series[pd.Timedelta]"), # type: ignore[assert-type] | ||
| pd.Series, | ||
| pd.Timedelta, | ||
| ) | ||
| check( | ||
| assert_type(s5.dt.as_unit("ms"), "pd.Series[pd.Timedelta]"), # type: ignore[assert-type] | ||
| pd.Series, | ||
| pd.Timedelta, | ||
| ) | ||
| check( | ||
| assert_type(s5.dt.as_unit("us"), "pd.Series[pd.Timedelta]"), # type: ignore[assert-type] | ||
| pd.Series, | ||
| pd.Timedelta, | ||
| ) | ||
| check( | ||
| assert_type(s5.dt.as_unit("ns"), "pd.Series[pd.Timedelta]"), # type: ignore[assert-type] | ||
| pd.Series, | ||
| pd.Timedelta, | ||
| ) |
There was a problem hiding this comment.
These type: ignores will be removed in #1273
Comment on lines
1756
to
1759
| @overload | ||
| def __sub__( | ||
| self, other: Timestamp | datetime | TimestampSeries | ||
| self, other: Timestamp | datetime | Series[Timestamp] | ||
| ) -> TimedeltaSeries: ... |
There was a problem hiding this comment.
Disabling mypy from recognising ss = s1 - s2 in test_series_min_max_sub_axis
There was a problem hiding this comment.
cmp0xff
commented
Jul 13, 2025
Comment on lines
+1618
to
+1621
| @overload | ||
| def __add__( | ||
| self: Series[Timestamp], other: _nonseries_timestamp | Series[Timestamp] | ||
| ) -> Never: ... |
There was a problem hiding this comment.
Disabling mypy from recognising Series[Any] + Series[Any] -> Series[Any] in test_sum_get_add and test_series_min_max_sub_axis
cmp0xff
commented
Jul 13, 2025
| check(assert_type(sa, pd.Series), pd.Series) | ||
| check(assert_type(ss, pd.Series), pd.Series) | ||
| check(assert_type(sa, pd.Series), pd.Series) # type: ignore[assert-type] | ||
| check(assert_type(ss, pd.Series), pd.Series) # type: ignore[assert-type] |
There was a problem hiding this comment.
cmp0xff
commented
Jul 13, 2025
Comment on lines
+2819
to
+2821
| check(assert_type(s + summer, pd.Series), pd.Series) # type: ignore[assert-type] | ||
| check(assert_type(s + df["y"], pd.Series), pd.Series) # type: ignore[assert-type] | ||
| check(assert_type(summer + summer, pd.Series), pd.Series) # type: ignore[assert-type] |
cmp0xff
commented
Jul 13, 2025
Comment on lines
+1271
to
+1273
| c_series_dt64: pd.Series[pd.Timestamp] = pd.Series( | ||
| [1, 2, 3], dtype="datetime64[ns]" | ||
| ) |
There was a problem hiding this comment.
Maybe
Suggested change
| c_series_dt64: pd.Series[pd.Timestamp] = pd.Series( | |
| [1, 2, 3], dtype="datetime64[ns]" | |
| ) | |
| c_series_dt64 = pd.Series([1, 2, 3], dtype="datetime64[ns]") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value