Skip to content

GH992 Fix pd.DataFrame.pct_change fill_method typing #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 5, 2024
Merged

GH992 Fix pd.DataFrame.pct_change fill_method typing #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6359e22
Adding new optional workflow
loicdiridollou Sep 2, 2024
bab6dae
Update new workflow
loicdiridollou Sep 2, 2024
1c3bd05
Update new workflow
loicdiridollou Sep 2, 2024
20e0603
GH992 Fix pd.DataFrame.pct_change fill_method typing
loicdiridollou Sep 3, 2024
8c1bc46
Update pandas-stubs/core/frame.pyi
loicdiridollou Sep 4, 2024
14855ea
PR Feedback
loicdiridollou Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas-stubs/core/frame.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1874,7 +1874,7 @@ class DataFrame(NDFrame, OpsMixin):
def pct_change(
self,
periods: int = ...,
fill_method: _str = ...,
fill_method: None = ...,
limit: int | None = ...,
freq=...,
**kwargs,
Expand Down
5 changes: 5 additions & 0 deletions tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,6 +2108,11 @@ def test_groupby_series_methods() -> None:
gb.nth(0).loc[1]


def test_dataframe_pct_change() -> None:
df = pd.DataFrame({"x": [1, 2, 2, 3, 3], "y": [10, 20, 30, 40, 50]})
df.pct_change(fill_method=None)


def test_indexslice_setitem():
df = pd.DataFrame(
{"x": [1, 2, 2, 3], "y": [1, 2, 3, 4], "z": [10, 20, 30, 40]}
Expand Down
Loading