Skip to content

CI: Fix npdev failures #58389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 24, 2024
Merged

CI: Fix npdev failures #58389

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cb1bcf
CI: Fix npdev failures
mroeschke Apr 23, 2024
4e9fbac
Use unique index, make array writable
mroeschke Apr 24, 2024
e6fcfe7
Update pandas/_libs/hashtable_class_helper.pxi.in
mroeschke Apr 24, 2024
1caf57b
Update pandas/tests/arrays/test_datetimelike.py
mroeschke Apr 24, 2024
fcfe702
Update pandas/tests/arrays/test_datetimelike.py
mroeschke Apr 24, 2024
624e873
Merge remote-tracking branch 'upstream/main' into ci/npdev
mroeschke Apr 24, 2024
3c1f256
Merge branch 'ci/npdev' of https://github.com/mroeschke/pandas into c…
mroeschke Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pandas/tests/arrays/test_datetimelike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,8 @@ def test_array_interface(self, datetime_index):
assert result is expected
tm.assert_numpy_array_equal(result, expected)
result = np.array(arr, dtype="datetime64[ns]")
assert result is not expected
if not np_version_gt2:
assert result is not expected
tm.assert_numpy_array_equal(result, expected)

# to object dtype
Expand Down Expand Up @@ -976,7 +977,9 @@ def test_array_interface(self, timedelta_index):
assert result is expected
tm.assert_numpy_array_equal(result, expected)
result = np.array(arr, dtype="timedelta64[ns]")
assert result is not expected
if not np_version_gt2:
# TODO: GH 57739
assert result is not expected
tm.assert_numpy_array_equal(result, expected)

# to object dtype
Expand Down
2 changes: 2 additions & 0 deletions pandas/tests/extension/base/missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ def test_isna_returns_copy(self, data_missing, na_func):
expected = result.copy()
mask = getattr(result, na_func)()
if isinstance(mask.dtype, pd.SparseDtype):
# TODO: GH 57739
mask = np.array(mask)
mask.flags.writeable = True

mask[:] = True
tm.assert_series_equal(result, expected)
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/indexes/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ def test_constructor_casting(self, index):
tm.assert_contains_all(arr, new_index)
tm.assert_index_equal(index, new_index)

@pytest.mark.parametrize("index", ["string"], indirect=True)
def test_constructor_copy(self, index, using_infer_string):
def test_constructor_copy(self, using_infer_string):
index = Index(list("abc"), name="name")
arr = np.array(index)
new_index = Index(arr, copy=True, name="name")
assert isinstance(new_index, Index)
Expand Down