Skip to content

String dtype: still return nullable NA-variant in object inference (maybe_converts_object) if requested #59487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 21, 2024
Merged

String dtype: still return nullable NA-variant in object inference (maybe_converts_object) if requested #59487

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
03d4943
String dtype: maybe_converts_object give precedence to nullable dtype
jorisvandenbossche Aug 12, 2024
c005778
update datetimelike input validation
jorisvandenbossche Aug 12, 2024
0bee1ac
update tests and remove xfails
jorisvandenbossche Aug 12, 2024
0057158
explicitly test pd.array() behaviour (remove xfail)
jorisvandenbossche Aug 12, 2024
c56c5f5
Merge remote-tracking branch 'upstream/main' into string-dtype-object…
jorisvandenbossche Aug 12, 2024
8af4cda
fixup allow_2d
jorisvandenbossche Aug 13, 2024
7b73c04
Merge remote-tracking branch 'upstream/main' into string-dtype-object…
jorisvandenbossche Aug 13, 2024
aa89c32
Merge remote-tracking branch 'upstream/main' into string-dtype-object…
jorisvandenbossche Aug 14, 2024
8b92517
undo changes related to datetimelike input validation
jorisvandenbossche Aug 14, 2024
548b501
fix test for str on current main
jorisvandenbossche Aug 20, 2024
5fbde9f
Merge remote-tracking branch 'upstream/main' into string-dtype-object…
jorisvandenbossche Aug 20, 2024
5cb76d0
Merge branch 'main' into string-dtype-object-conversion
mroeschke Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2699,16 +2699,16 @@ def maybe_convert_objects(ndarray[object] objects,
seen.object_ = True

elif seen.str_:
if using_string_dtype() and is_string_array(objects, skipna=True):
if convert_to_nullable_dtype and is_string_array(objects, skipna=True):
from pandas.core.arrays.string_ import StringDtype

dtype = StringDtype(na_value=np.nan)
dtype = StringDtype()
return dtype.construct_array_type()._from_sequence(objects, dtype=dtype)

elif convert_to_nullable_dtype and is_string_array(objects, skipna=True):
elif using_string_dtype() and is_string_array(objects, skipna=True):
from pandas.core.arrays.string_ import StringDtype

dtype = StringDtype()
dtype = StringDtype(na_value=np.nan)
return dtype.construct_array_type()._from_sequence(objects, dtype=dtype)
Comment on lines -2702 to 2712
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially this diff is just switching the order of the if/elif blocks, to first check if we want a nullable dtype and only then check if we want the future default string dtype.


seen.object_ = True
Expand Down
Loading