Skip to content

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Sep 6, 2024

xref #59726
The shared docs for idxmin and idxmax are used only in the class DataFrame. Series.idxmin/idxmax and core.groupby.SeriesGroupBy.idxmin/idxmax have their own docstrings.

I moved the idxmin and idxmax docstrings from shared_docs.py to core/frame.py and corrected the description of skipna parameter.

@natmokval natmokval added the Docs label Sep 6, 2024
@natmokval natmokval changed the title DOC: move DataFrame.idxmin and DataFrame.idxmax docstrings to core/frame.py DOC: move idxmin and idxmax docs from core/shared_docs.py to core/frame.py Sep 6, 2024
@natmokval natmokval marked this pull request as ready for review September 6, 2024 14:04
@mroeschke mroeschke added this to the 3.0 milestone Sep 6, 2024
@mroeschke mroeschke merged commit 5a3a4f3 into pandas-dev:main Sep 6, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @natmokval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants