REF: remove unreachable, stronger typing in parsers.pyx #61785
Merged
+88
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
force-pushed
the
ref-na_fvalues
branch
from
31fa1fb to
ef14cb7
Compare
mroeschke
approved these changes
Jul 7, 2025
| # (tests for this case are in test_na_values.py) | ||
| if not isinstance(na_values, dict): | ||
| # i.e. it must be a set | ||
| na_values = list(na_values) |
There was a problem hiding this comment.
IIUC in this file, it appears usages where this is a list could be a set with some Cython annotations changed, so the annotation of na_values here could match what is gotten from the caller.
There was a problem hiding this comment.
We end up passing it to kset_from_list, which is used in two other places with a list. I decided that was a bit more invasive than I want to get ATM.
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.