DOC: fix doctests for pandas/core/generic.py for new string dtype #61907
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doctests (asof and squeeze)
pandas/core/generic.py
Outdated
| @@ -885,7 +885,7 @@ def squeeze(self, axis: Axis | None = None) -> Scalar | Series | DataFrame: | |||
| dtype: int64 | |||
|
|
|||
| >>> even_primes.squeeze() | |||
| np.int64(2) | |||
| 2 | |||
There was a problem hiding this comment.
With which version of numpy are you running the doctests locally?
I personally don't particularly like the np.int64(2) repr for in the docstrings, but I see that was recently changed in #60987 to follow the latest numpy
There was a problem hiding this comment.
Ah right, thanks for catching that. I’ll revert it
pandas/core/generic.py
Outdated
| @@ -11804,7 +11804,7 @@ def first_valid_index(self) -> Hashable: | |||
| >>> print(df.last_valid_index()) | |||
| None | |||
|
|
|||
| If all elements in DataFrame are NA/null, returns None. | |||
| If all elements in DataFrame are NA/null, returns NaN. | |||
There was a problem hiding this comment.
The example below still shows None?
jorisvandenbossche
approved these changes
Jul 21, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #xxxx (Replace xxxx with the GitHub issue number)Added type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Part of #61886