#61382: FIX MultiIndex.difference for pyarrow-backed Timestamps #62127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpibad
commented
Aug 15, 2025
arpibad
commented
- Override MultiIndex.difference to handle Timestamp[ns][pyarrow] levels
- Ensure proper comparison without converting all levels to pandas types
- Add pytest test for difference with pyarrow-backed MultiIndex
- Override MultiIndex.difference to handle Timestamp[ns][pyarrow] levels - Ensure proper comparison without converting all levels to pandas types - Add pytest test for difference with pyarrow-backed MultiIndex
| @@ -4135,6 +4135,33 @@ def isin(self, values, level=None) -> npt.NDArray[np.bool_]: | |||
| # base class "Index" defined the type as "Callable[[Index, Any, bool], Any]") | |||
| rename = Index.set_names # type: ignore[assignment] | |||
|
|
|||
| def difference(self, other, sort=None): | |||
There was a problem hiding this comment.
this seems really unlikely to be the right place to handle this. if you step through the existing implementation, where is the first step that goes wrong?
|
|
||
| pytest.importorskip("pyarrow") | ||
|
|
||
| def test_difference_with_pyarrow_timestamp(): |
There was a problem hiding this comment.
this would go in tests/indexes/multi/test_setops.py
|
@arpibad you don't want to keep pursuing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.