BUG: DatetimeIndex intersection with non-anchored freq #62341
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/indexes/datetimelike.py
Outdated
| def _can_fast_intersect(self, other: Self) -> bool: | ||
| # Note: we only get here with len(self) > 0 and len(other) > 0 | ||
| if self.freq is None: | ||
| if self.freq is None or self.freq == "C": |
There was a problem hiding this comment.
the issue isn't just handling "C", but identifying what conditions work in the general case
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
@arthurlw are you still working on this? |
|
Hey @jbrockmendel, i've been a bit swamped with classwork lately. I updated the condition in the PR. Lmk if anything needs to be changed! |
| # indexes actually share a common point | ||
| # GH#44025 | ||
| diff = other[0] - self[0] | ||
| if diff != Timedelta(0) and diff.total_seconds() % 86400 != 0: |
There was a problem hiding this comment.
clearer just to write diff != Timedelta(days=1)?
There was a problem hiding this comment.
of never mind, didn't see the %
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.