Fix/53098 numeric only disallow non bools #62632
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numeric_only
in reduction operations should disallow passing non-bools #53098 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Ran tests:
Groupby tests: 29766 passed, 440 skipped, 45 xfailed, 39 xpassed, 1 warning.
Window tests (with Numba disabled to avoid an env crash): 9869 passed, 28 skipped, 91 xfailed.
Frame reductions tests: 2338 passed, 2 xfailed.
No real test failures (only xfails/skips) after applying the deprecation behavior.
Changes
Implemented the deprecation approach for numeric_only=None during the 2.x cycle:
frame.py : (DataFrame._reduce)
series.py : (Series._reduce)
groupby.py :(GroupBy._cython_agg_general)
rolling.py : (Rolling._validate_numeric_only)