API: Disallow DataFrame other for Series flex ops #62648
Conversation
|
Thanks @jbrockmendel |
| result = self._binop(other, op, level=level, fill_value=fill_value) | ||
| result._name = res_name | ||
| return result | ||
| elif isinstance(other, ABCDataFrame): |
There was a problem hiding this comment.
Actually last minute thought, would be worth still allowing this if the axis are already aligned?
There was a problem hiding this comment.
so just revert and let non-aligned cases raises like before? maybe try to give a better message?
There was a problem hiding this comment.
Or if ser.flex_op(df, axis=0) gives a sensible result when ser.index.equals(df.index), just have a follow up PR to amend and not ser.index.equals(df.index) to this elif. I suppose it would be good to also have a test case for ser.flex_op(df, axis=0) when the indexes are aligned
There was a problem hiding this comment.
i think "DataFrame is not allowed" is significantly simpler to communicate than "DataFrame is not allowed except when aligned"
There was a problem hiding this comment.
Yeah definitely. We can keep this as is and reconsider if anyone seriously complains
2 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.