Skip to content

Conversation

@ingo-stallknecht
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

What changes are proposed in this pull request?

This PR adds tests for DataFrame.equals with Categorical columns:

  • Verifies that DataFrames are considered equal when values and categories are the same, even if the category order differs.
  • Verifies that DataFrames are not equal when the category set differs.

This helps improve test coverage for equals on Categorical data.

How is this PR tested?

  • New test in pandas/tests/frame/methods/test_equals.py

@ingo-stallknecht
Copy link
Contributor Author

It looks like the micromamba cache step failed (ENOENT), which seems unrelated to this PR.
Let me know if I should rebase or push an update to retrigger CI.

@mroeschke
Copy link
Member

Is there an open issue associated with this?

@ingo-stallknecht
Copy link
Contributor Author

No, there is no open issue associated with this PR.

@mroeschke mroeschke added this to the 3.0 milestone Dec 4, 2025
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Dec 4, 2025
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Next time, could you open an issue first so the maintainers can triage and understand more context?

@mroeschke mroeschke merged commit fa1360d into pandas-dev:main Dec 4, 2025
46 checks passed
@ingo-stallknecht
Copy link
Contributor Author

Yes, will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants