TST: Add regression test for DataFrame.where inplace consistency #63259
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test for GH#46512 - Bug was fixed - inplace and non-inplace now behave consistently - Test ensures StringArray with NA-like values works correctly - Both inplace=True and inplace=False now return pd.NA consistently Closes pandas-dev#46512
mroeschke
requested changes
Dec 4, 2025
Comment on lines
+1079
to
+1080
| # GH#46512 - inplace and non-inplace should have consistent behavior | ||
| # for StringArray with NA-like values |
Member
There was a problem hiding this comment.
Please remove all comments (and below) except GH#46512
Comment on lines
+1090
to
+1092
| # Both should produce pd.NA, not float nan | ||
| assert isinstance(result["A"]._values[1], type(pd.NA)) | ||
| assert isinstance(df_inplace["A"]._values[1], type(pd.NA)) |
Member
There was a problem hiding this comment.
Suggested change
| # Both should produce pd.NA, not float nan | |
| assert isinstance(result["A"]._values[1], type(pd.NA)) | |
| assert isinstance(df_inplace["A"]._values[1], type(pd.NA)) |
This isn't needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds regression test for inconsistent behavior between
DataFrame.wherewithinplace=Trueandinplace=Falsewhen using StringArray with NA-like values.Background
inplace=Truewould incorrectly storefloat
nanwhileinplace=Falsestoredpd.NAuse
pd.NAChanges
test_where_inplace_string_array_consistency()topandas/tests/frame/indexing/test_where.pyinplace=Trueandinplace=Falseproduce identicalresults with
pd.NAfor StringArrayTesting
pytest pandas/tests/frame/indexing/test_where.py::test_where_inplace_string_array_consistency -v
PASSED
Closes #46512
[x] Tests added and passed
[x] All code checks passed (will verify in CI)
[ ] Added type annotations (N/A - test only)
[ ] Added whatsnew entry (N/A - test only)
[x] Used AI following AGENTS.md