Add global move selected window hotkey #1082
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only implemented horizontally, but done in one commit to avoid updating the compiled gschema twice.
This was referenced Sep 26, 2025
smichel17
commented
Sep 26, 2025
There was a problem hiding this comment.
Neither this nor the other PRs are my cleanest code… there is a fair amount of duplicate index-finding now that we could probably clean up. But I wasn't sure how much the implementation would diverge, so I opted for copy-pasting the relevant pieces of logic instead of reusing functions, to give freedom to change whatever is needed.
tiling.js
Outdated
| } | ||
| let column = this[index]; | ||
| if (targetRow < 0 || targetRow >= column.length) { | ||
| // TODO: Move to workspace above/below |
There was a problem hiding this comment.
I need to give more thought to how switching up/down should work when there is a monitor above.
Only kind of works.. when moving to a monitor to the side, then down, you end up back on the first monitor.
smichel17
force-pushed
the
sm/global-move
branch
from
176a0f9 to
27e787e
Compare
This was referenced Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs. See the first one for more context.
This is backwards compatible. However, I think we should eventually make this the default (after I have used it for a long period of time and the animations are improved). So, I updated the text to make this one described as just "move window to the left" and clarified that the current default stays on the same monitor.