Add link to new BP en ligne #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BP en ligne has a new web address, and has at my request implemented URIs that lack ampersands, to permit the modification of PN XSLT, to generate hyperlinks to BP from our biblio records. This commit defines a variable `$bpIdno` as the value of `//t:idno[@type='bp']` and then calls that variable twice: once in html's `a/@href` (where it is concatenated with the new web address endpoint, as its parameter), and once as the value of that `a/@href` element.
Contributor
|
@samosafuz I just pushed a fix for this to the main branch. For the sake of this pull request, I don't think you'll see the fixed test run unless you rebase your original branch on top of the updated master branch. However, I think it's probably safe to merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP en ligne has a new web address, and has at my request implemented URIs that lack ampersands, to permit the modification of PN XSLT, to generate hyperlinks to BP from our biblio records.
This commit defines a variable
$bpIdnoas the value of//t:idno[@type='bp']and then calls that variable twice: once in html'sa/@href(where it is concatenated with the new web address endpoint, as its parameter), and once as the value of thata/@hrefelement.