Skip to content

perf(reth-engine-local): use VecDeque reduce removal operations #18198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

perf(reth-engine-local): use VecDeque reduce removal operations #18198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/engine/local/src/miner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ use reth_payload_primitives::{
use reth_provider::BlockReader;
use reth_transaction_pool::TransactionPool;
use std::{
collections::VecDeque,
future::Future,
pin::Pin,
task::{Context, Poll},
Expand Down Expand Up @@ -108,7 +109,7 @@ pub struct LocalMiner<T: PayloadTypes, B, Pool: TransactionPool + Unpin> {
/// Timestamp for the next block.
last_timestamp: u64,
/// Stores latest mined blocks.
last_block_hashes: Vec<B256>,
last_block_hashes: VecDeque<B256>,
}

impl<T, B, Pool> LocalMiner<T, B, Pool>
Expand All @@ -134,7 +135,7 @@ where
mode,
payload_builder,
last_timestamp: latest_header.timestamp(),
last_block_hashes: vec![latest_header.hash()],
last_block_hashes: VecDeque::from([latest_header.hash()]),
}
}

Expand Down Expand Up @@ -162,7 +163,7 @@ where
/// Returns current forkchoice state.
fn forkchoice_state(&self) -> ForkchoiceState {
ForkchoiceState {
head_block_hash: *self.last_block_hashes.last().expect("at least 1 block exists"),
head_block_hash: *self.last_block_hashes.back().expect("at least 1 block exists"),
safe_block_hash: *self
.last_block_hashes
.get(self.last_block_hashes.len().saturating_sub(32))
Expand Down Expand Up @@ -230,11 +231,10 @@ where
}

self.last_timestamp = timestamp;
self.last_block_hashes.push(block.hash());
self.last_block_hashes.push_back(block.hash());
// ensure we keep at most 64 blocks
if self.last_block_hashes.len() > 64 {
self.last_block_hashes =
self.last_block_hashes.split_off(self.last_block_hashes.len() - 64);
self.last_block_hashes.pop_front();
}

Ok(())
Expand Down