fix: Inline value match in SparseTrie::find_leaf to remove redundant wrapper #19138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anim001k
requested review from
Rjected,
mediocregopher,
rkrasiuk and
shekhirin
as code owners
This was already the case as far as I can tell |
shekhirin
requested changes
Oct 21, 2025
| expected_value: Option<&Vec<u8>>, | ||
| ) -> Result<LeafLookup, LeafLookupError> { | ||
| // Helper function to check if a value matches the expected value | ||
| fn check_value_match( |
There was a problem hiding this comment.
can we just add an #[inline] attribute here? It doesn't clone the value unless the error is returned anyway, as @mediocregopher said.
|
@shekhirin any updates yet? |
shekhirin
requested changes
Oct 24, 2025
crates/trie/sparse/src/trie.rs
Outdated
| self.rlp_buf.clear(); | ||
| } | ||
|
|
||
| #[inline] |
There was a problem hiding this comment.
sorry, I meant adding an #[inline] attribute on check_value_match, and that's basically the only change that's needed in this PR, because we already don't clone anything until we return the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace local helper function
check_value_matchwith inlined comparison inSparseTrie::find_leaf.Avoids a redundant wrapper and defers cloning
Vec<u8>until error construction.Rationale: