Skip to content

perf: eliminate bounds check in PrefixSet::contains while loop #19191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

perf: eliminate bounds check in PrefixSet::contains while loop #19191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e3233
perf: eliminate bounds check in PrefixSet::contains while loop
gancerlory Oct 21, 2025
77284ca
resetting index = 0
gancerlory Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/trie/common/src/prefix_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ impl PrefixSet {
return true
}

// Early bounds check to help compiler eliminate redundant checks in the while loop
// If index is out of bounds, reset to 0 to avoid unnecessary backward scanning
if self.index >= self.keys.len() {
self.index = 0;
}

while self.index > 0 && &self.keys[self.index] > prefix {
self.index -= 1;
}
Expand Down