Skip to content

Conversation

@reject-i
Copy link
Contributor

Running cargo test -p reth-primitives-traits --lib --no-default-features was failing with unresolved import rustc_hash error because rustc_hash::FxHashMap was imported with only std feature but rustc-hash dependency requires rustc-hash feature.

Fixed conditional compilation to require both std and rustc-hash features for FxHashMap import and added std::HashMap fallback when rustc-hash is disabled.

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 22, 2025
@reject-i
Copy link
Contributor Author

@mattsse removed the optional rustc-hash feature so the crate now always depends on it and switches to FxHashMap whenever std is on
cargo test -p reth-primitives-traits --lib --no-default-features gets past the previous rustc_hash import error and only hits the long-standing modular_bitfield issue (that crate is still optional unless reth-codec is enabled), which predates this pr

would you like me to fix that here as well, or should I spin it out into a follow-up pr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants