fix: hive tests consume test suite #19240
Conversation
jenpaff
force-pushed
the
jenpaff/update-hive-tests-consume-suite
branch
from
0dd86e3 to
c2add1c
Compare
jenpaff
force-pushed
the
jenpaff/update-hive-tests-consume-suite
branch
2 times, most recently
from
018d8e4 to
308fd0a
Compare
| # Run each hive command in the background for each simulator and wait | ||
| echo "Building images" | ||
| ./hive -client reth --sim "ethereum/eest" --sim.buildarg fixtures=https://github.com/ethereum/execution-spec-tests/releases/download/v5.3.0/fixtures_develop.tar.gz --sim.buildarg branch=v5.3.0 -sim.timelimit 1s || true & | ||
| ./hive -client reth --sim "ethereum/eels" --sim.buildarg fixtures=https://github.com/ethereum/execution-spec-tests/releases/download/v5.3.0/fixtures_develop.tar.gz -sim.timelimit 1s || true & |
There was a problem hiding this comment.
we no longer pin to any branch, is this ok? @fgimenez
There was a problem hiding this comment.
i believe it would be better to keep the branch pin, otherwise we would be open to failures due to unreleased changes landing on eels repo main branch
There was a problem hiding this comment.
it was failing during the build step , but can take another look
There was a problem hiding this comment.
yep, looks like tests are being migrated to https://github.com/ethereum/execution-specs and the simulator is built from this repo now in hive, but the tags are different from what we had in the old repo, and fixtures still come from the old one
just added a TODO comment to pin the image once we have proper tags and fixtures coming from the new repo
There was a problem hiding this comment.
From the readme
Client Teams: Test fixture releases will continue from ethereum/execution-spec-tests as usual. No changes to your consumption workflow.
There was a problem hiding this comment.
thx! will update the TODO to reflect this
Co-authored-by: Federico Gimenez <[email protected]>
follow up from #19230
re-running hive test from branch before merging https://github.com/paradigmxyz/reth/actions/runs/18777666039