feat(metrics): add push gateway support for Prometheus metrics #19243
+125
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigurable interval
mablr
commented
Oct 22, 2025
There was a problem hiding this comment.
I tested it locally like this :
docker run -d -p 9091:9091 prom/pushgateway
reth node --metrics=0.0.0.0:9001 --metrics.push.url=http://localhost:9091/metrics/job/test
curl http://localhost:9091/metrics
It seems to push correctly.
I'm wondering if it's relevant to add a test that spawns a HTTP server in order to inspect the PUT requests sent by the MetricServer. Wdyt ?
mablr
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
shekhirin
requested changes
Oct 23, 2025
shekhirin
added
C-enhancement
shekhirin
reviewed
Oct 23, 2025
shekhirin
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19229
This spawns a task to push metrics to prometheus following configurable interval (default 5sec).
Added CLI flags for push gateway url and push interval.