- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.1k
feat(op-reth): implement miner_setGasLimit RPC #19247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            frankudoags
  wants to merge
  11
  commits into
  paradigmxyz:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
frankudoags:frank-miner_setGasLimit
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            feat(op-reth): implement miner_setGasLimit RPC #19247
                    frankudoags
  wants to merge
  11
  commits into
  paradigmxyz:main
from
frankudoags:frank-miner_setGasLimit
  
      
      
   
              
            
      
        
          +121
        
        
          −13
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    mattsse
  
              
              requested changes
              
                  
                    Oct 23, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool,
some nits
…onfig Introduce a shareable OpGasLimitConfig (backed by AtomicU64) to manage per-transaction gas limits with getter/setter semantics (0 => use default). Add a gas_limit_config field to OpBuilderConfig and update OpBuilderConfig::new signature accordingly. Include unit tests for gas limit behavior.
…gas_limit metric Add OpGasLimitConfig field and constructor parameter to OpMinerExtApi, introduce a gas_limit Gauge and setter in OpMinerMetrics, and restore the placeholder miner_setGasLimit handler (commented).
… and payload builder Wire OpGasLimitConfig into OpNode, OpAddOns, OpAddOnsBuilder, OpPayloadBuilder and OpMinerExtApi. Add default initialization and with_gas_limit_config helpers, and include gas_limit_config in OpBuilderConfig passed to the payload builder.
feat(optimism/rpc): implement miner_setGasLimit RPC handler - Update Cargo.toml/Cargo.lock to source op-alloy crates from git rev 47ecf4a. - Un-comment and implement miner set_gas_limit to apply OpGasLimitConfig and update metrics.
…emove pinned git rev) Enable op-alloy crates from the registry in Cargo.toml and remove the git rev pins; update Cargo.lock accordingly.
58bd6c0    to
    c6f7ccb      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
closes #19236