Skip to content

Conversation

@Peponks9
Copy link
Contributor

Description

this PR implements the requested impl method from issue #19239

Changes

  • added add_or_replace_if_module_configured. It adds or replaces methods only in transports (HTTP, WS, IPC) where the specified.
  • added test_add_or_replace_if_module_configured to verify the function handles add/replace operations correctly across configured transports and skips unconfigured ones.

Testing

  • all existing tests pass.

Closes #19239

- Add unit test to verify behavior across HTTP, WS, and IPC transports
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 24, 2025
@mattsse mattsse added this pull request to the merge queue Oct 24, 2025
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Oct 24, 2025
Merged via the queue into paradigmxyz:main with commit ddcfc8a Oct 24, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add TransportRpcModules::add_or_replace_if_module_configured(

2 participants