Update trie-db version to 0.28.0 #1522
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
A1-insubstantial
| // that the value doesn't exist in the trie. | ||
| self.update_recorded_keys(full_key, RecordedForKey::Value); | ||
| }, | ||
| TrieAccess::InlineValue { full_key } => { |
There was a problem hiding this comment.
@bkchr Would like to double check this with you 🙏
(introduced by: paritytech/trie#194)
| // Non-existing access means we recorded all trie nodes up to the value. | ||
| // Not the actual value, as it doesn't exist, but all trie nodes to know | ||
| // that the value doesn't exist in the trie. | ||
| self.update_recorded_keys(full_key, RecordedForKey::Value); |
There was a problem hiding this comment.
this should switch to RecordedForKey::None I think
There was a problem hiding this comment.
No the current value is correct. The comment also says why we pass there Value.
There was a problem hiding this comment.
I don't understand it (this did make sense to me).
There was a problem hiding this comment.
Good find 🙈
See this docs: https://github.com/paritytech/trie/blob/692ee41a6bd0df36252663d2f7974ab1c368d9a0/trie-db/src/lib.rs#L193-L220
Maybe I should have given None a different name, but the docs are explaining it.
| // Non-existing access means we recorded all trie nodes up to the value. | ||
| // Not the actual value, as it doesn't exist, but all trie nodes to know | ||
| // that the value doesn't exist in the trie. | ||
| self.update_recorded_keys(full_key, RecordedForKey::Value); |
There was a problem hiding this comment.
No the current value is correct. The comment also says why we pass there Value.
Co-authored-by: Bastian Köcher <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
This PR updates: - trie-db from 0.27.1 to 0.28.0 - trie-bench from 0.37.0 to 0.38.0 (deb-dependency) While at it, also adapts the recorder to take into account the newly added `TrieAccess::InlineValue`. Needed by: - paritytech#1153 @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
4 participants
This PR updates:
While at it, also adapts the recorder to take into account the newly added
TrieAccess::InlineValue.Needed by:
@paritytech/subxt-team