Skip to content

Handle malformed assertion signatures #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
explunit wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −5
Open

Handle malformed assertion signatures #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions Tests/Fido2.Tests/AuthenticatorResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2461,8 +2461,12 @@ public async Task TestAuthenticatorAssertionStoredPublicKeyMissing()
Assert.Equal(Fido2ErrorMessages.MissingStoredPublicKey, ex.Message);
}

[Fact]
public async Task TestAuthenticatorAssertionInvalidSignature()
[Theory]
[InlineData(new byte[] { 0x30, 0x00 }, true)]
[InlineData(new byte[] { 0x30, 0x00 }, false)]
[InlineData(new byte[] { 0xf1, 0xd0 }, true)]
[InlineData(new byte[] { 0xf1, 0xd0 }, false)]
public async Task TestAuthenticatorAssertionInvalidSignature(byte[] signature, bool useEdDsa)
{
var challenge = RandomNumberGenerator.GetBytes(128);
var rp = "https://www.passwordless.dev";
Expand All @@ -2488,7 +2492,7 @@ public async Task TestAuthenticatorAssertionInvalidSignature()
var assertion = new AuthenticatorAssertionRawResponse.AssertionResponse()
{
AuthenticatorData = new AuthenticatorData(SHA256.HashData(Encoding.UTF8.GetBytes(rp)), AuthenticatorFlags.UP | AuthenticatorFlags.UV, 0, null, new Extensions(new byte[] { 0x42 })).ToByteArray(),
Signature = [0xf1, 0xd0],
Signature = signature,
ClientDataJson = clientDataJson,
UserHandle = [0xf1, 0xd0],
};
Expand Down Expand Up @@ -2526,12 +2530,23 @@ public async Task TestAuthenticatorAssertionInvalidSignature()
return Task.FromResult(true);
};

fido2_net_lib.Test.Fido2Tests.MakeEdDSA(out _, out var publicKey, out var privateKey);
byte[] publicKeyBytes;
if (useEdDsa)
{
fido2_net_lib.Test.Fido2Tests.MakeEdDSA(out _, out var publicKey, out var privateKey);
publicKeyBytes = fido2_net_lib.Test.Fido2Tests.MakeCredentialPublicKey(COSE.KeyType.OKP, COSE.Algorithm.EdDSA, COSE.EllipticCurve.Ed25519, publicKey).GetBytes();
}
else
{
using var ecdsa = fido2_net_lib.Test.Fido2Tests.MakeECDsa(COSE.Algorithm.ES256, COSE.EllipticCurve.P256);
publicKeyBytes = new CredentialPublicKey(ecdsa, COSE.Algorithm.ES256).GetBytes();
}

var ex = await Assert.ThrowsAsync<Fido2VerificationException>(() => lib.MakeAssertionAsync(new MakeAssertionParams
{
AssertionResponse = assertionResponse,
OriginalOptions = options,
StoredPublicKey = fido2_net_lib.Test.Fido2Tests.MakeCredentialPublicKey(COSE.KeyType.OKP, COSE.Algorithm.EdDSA, COSE.EllipticCurve.Ed25519, publicKey).GetBytes(),
StoredPublicKey = publicKeyBytes,
StoredSignatureCounter = 0,
IsUserHandleOwnerOfCredentialIdCallback = callback
}));
Expand Down