Add new #[SubscriptionId] attribute to replace SubscritionUtil trait
#791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBadura
commented
Nov 23, 2025
| { | ||
| public function __construct( | ||
| public readonly string $id, | ||
| public readonly string|null $id = null, |
Member
Author
There was a problem hiding this comment.
should be re-orderd i guess
| use Patchlevel\EventSourcing\Tests\Integration\Subscription\Events\ProfileCreated; | ||
|
|
||
| #[Subscriber('lookup', RunMode::FromBeginning)] | ||
| #[Subscriber(runMode: RunMode::FromBeginning)] |
Member
Author
There was a problem hiding this comment.
Don't know why this currently does not work as I'm using here a name parameter and id has now a default null value, php stillt trips here with ArgumentCountError: Patchlevel\EventSourcing\Attribute\Subscriber::__construct(): Argument #1 ($id) not passed
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
reviewed
Nov 24, 2025
DanielBadura
force-pushed
the
add-subscription-name
branch
from
a04cfbe to
d2bc4d5
Compare
DanielBadura
changed the title
#[SubscriptionName] attribute to replace SubscritionUtil trait#[SubscriptionId] attribute to replace SubscritionUtil trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #743