This repository was archived by the owner on Sep 18, 2019. It is now read-only.
Update layout-picker-custom-control.php #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout picker was not working at all. It had a `<label>` wrapping all inputs. Only one option could be selected. `$this->link()` was missed in the inputs and current value was not checked.
Update label class to match CSS selector used by Wordpress. Fixed cache time compare of the Google font file
Change `wp_dropdown_cats` to `wp_dropdown_categories` to avoid deprecated warnings (`wp_dropdown_cats` was deprecated in Wordpress 3.0)
Use WP_Filesystem instead of direct PHP file functions
|
Thanks for the fix, works like a charm! Hope the pull request gets accepted someday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout picker was not working at all. It had a
<label>wrapping all inputs. Only one option could be selected.$this->link()was missed in the inputs and current value was not checked.