-
Notifications
You must be signed in to change notification settings - Fork 0
feat(biometric): implement biometric authentication for app security #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
4
commits into
staging
Choose a base branch
from
copilot/fix-1990560e-34bb-4d2d-9ffc-f1c726bb3e03
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+282
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pawcoding <[email protected]>
Copilot finished work on behalf of
pawcoding
September 30, 2025 18:56
pawcoding
requested changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looks pretty good, @copilot 🦾!
Just a few tweaks before this is ready to be shipped.
Co-authored-by: pawcoding <[email protected]>
Copilot finished work on behalf of
pawcoding
October 3, 2025 16:52
pawcoding
requested changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review @copilot
app/src/main/java/de/pawcode/cardstore/data/managers/PreferencesManager.kt
Outdated
Show resolved
Hide resolved
…component Co-authored-by: pawcoding <[email protected]>
Copilot finished work on behalf of
pawcoding
October 3, 2025 18:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biometric Authentication Implementation ✅
Completed Tasks
Latest Changes (Round 2 Feedback)
1. In-Memory Authentication Time
lastAuthTime
persistence from PreferencesManagerLAST_AUTH_TIME
key and related methodslastAuthTime
as a private property in MainActivity2. Extracted BiometricPlaceholder Component
BiometricPlaceholder.kt
inui/components
@Preview
annotation for component previewFiles Modified
PreferencesManager.kt
- Removed lastAuthTime persistenceMainActivity.kt
- Use in-memory lastAuthTime, removed inline BiometricPlaceholderAboutScreen.kt
- Removed call to saveLastAuthTimeBiometricPlaceholder.kt
- NEW - Extracted component with previewBuild Status
✅ Code formatted with
ktfmtFormat
✅ Build successful with
assembleDebug
✅ All feedback addressed
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.