Skip to content

fix(storage-s3): validate Content-Length before appending header #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

fix(storage-s3): validate Content-Length before appending header #13472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74a90c8
fix(storage-s3): validate Content-Length before appending header
id3er0 Aug 14, 2025
aa20111
Merge branch 'payloadcms:main' into fix/s3-content-length-validation
id3er0 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/storage-s3/src/staticHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,14 @@ export const getHandler = ({

let headers = new Headers(incomingHeaders)

headers.append('Content-Length', String(object.ContentLength))
// Only include Content-Length when it’s present and strictly numeric.
// This prevents "Parse Error: Invalid character in Content-Length" when providers (e.g., MinIO)
// return undefined or a non-numeric value.
const contentLength = String(object.ContentLength);
if (contentLength && !isNaN(Number(contentLength))) {
headers.append('Content-Length', contentLength);
}

headers.append('Content-Type', String(object.ContentType))
headers.append('Accept-Ranges', String(object.AcceptRanges))
headers.append('ETag', String(object.ETag))
Expand Down
Loading