-
Notifications
You must be signed in to change notification settings - Fork 62
Get low scoped access token #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement FetchClientToken class for OAuth2 client credentials flow - Add headers parameter to APIRequest for Basic auth support - Convert PayPalWebCheckoutClient.start() to suspend function - Integrate token fetching before launching web checkout - Add comprehensive error handling for token fetch failures
sshropshire
reviewed
Jun 25, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jun 25, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jun 25, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jun 25, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jun 25, 2025
CorePayments/src/test/java/com/paypal/android/corepayments/api/FetchClientTokenUnitTest.kt
Outdated
Show resolved
Hide resolved
45a4537
to
071680b
Compare
...nts/src/main/java/com/paypal/android/corepayments/api/AuthenticationSecureTokenServiceAPI.kt
Outdated
Show resolved
Hide resolved
754dd35
to
cdbf235
Compare
sshropshire
reviewed
Jul 3, 2025
...nts/src/main/java/com/paypal/android/corepayments/api/AuthenticationSecureTokenServiceAPI.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jul 3, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/APIClientError.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jul 3, 2025
...nts/src/main/java/com/paypal/android/corepayments/api/AuthenticationSecureTokenServiceAPI.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Jul 3, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/api/GetClientTokenResult.kt
Outdated
Show resolved
Hide resolved
sshropshire
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple take or leave 🧶 's but overall LGTM
cdbf235
to
ece60f6
Compare
…terface - Create PayPalWebCheckoutCallback fun interface following CardApproveOrderCallback pattern - Add overloaded start() function accepting PayPalWebCheckoutCallback
ece60f6
to
cf9bece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
PaypalWebCheckoutClient
Checklist
Authors