Skip to content

Conversation

@mnicpt
Copy link
Contributor

@mnicpt mnicpt commented Oct 16, 2025

What is the purpose of this PR?

Adds two props to button component for Venmo:

  1. supportsVenmoPopups
  2. supportedNativeVenmoBrowser

Jira Ticket: https://paypal.atlassian.net/browse/DTPPCPSDK-3139

Type of change

  • New feature (backward compatible change that adds new capability).
  • UI change
  • Bug fix.
  • Breaking change (backward incompatible change). Provide references to customer impact and communication.
  • Refactor (no functional change)

Testing Plan

Below is information that validates the successful implementation of this feature and how a release manager can validate the success of a release candidate in the absence of the PR author.
PR Author: https://paypal.enterprise.slack.com/team/W013SUFRA1X
Backup Validator: https://paypal.enterprise.slack.com/team/W0180EVTD2A
PR Author's Team: Venmo Web Team
PP Test Page URL: https://github.paypal.com/pages/Core-SDK/paypalsdktestingnodeweb/?path=/story/button-rebrand-smart-stack-layout--vertical&globals=sdkEnvironment:testEnv;testEnvName:te-sdk-release-5-0-
BE SURE TO PUT VERSION IN URL ABOVE

Venmo Test Page URL:
https://github.paypal.com/pages/Core-SDK/paypalsdktestingnodeweb/?path=/story/no-code-buttons-ncps--button-one&globals=testEnvName:te-sdk-release-5-0-507
OR
https://www.cibns.stage.paypal.com/xo-integrations/venmo

**NOTE:**Check the following with SDK Namespace paypal and paypalRebrand

Step-by-Step Validation for iOS/Chrome change using PP test page

iOS

  1. Step one: Select SmartStack->layout->vertical

  2. Step two: Select paypal namespace

  3. Step three: Verify Venmo button is rendered, no errors in console and /js and /buttons return successfully

  4. Step one: Select SmartStack->layout->vertical

  5. Step two: Select paypalRebrand namespace

  6. Step three: Verify Venmo button is rendered, no errors in console and /js and /buttons return successfully

Step-by-Step Validation for Firefox change using PP test page

iOS

  1. Step one: Select SmartStack->layout->vertical

  2. Step two: Select paypal namespace

  3. Step three: Verify Venmo button is not rendered, no errors in console and /js and /buttons return successfully

  4. Step one: Select SmartStack->layout->vertical

  5. Step two: Select paypalRebrand namespace

  6. Step three: Verify Venmo button is not rendered, no errors in console and /js and /buttons return successfully

Android

  1. Step one: Select SmartStack->layout->vertical

  2. Step two: Select paypal namespace

  3. Step three: Verify Venmo button is not rendered, no errors in console and /js and /buttons return successfully

  4. Step one: Select SmartStack->layout->vertical

  5. Step two: Select paypalRebrand namespace

  6. Step three: Verify Venmo button is not rendered, no errors in console and /js and /buttons return successfully

Default browser validation

Follow same steps above but with iOS/Safari and Android/Chrome

Screenshots

iOS/Firefox:
image

iOS/Safari, Android/Chrome, Android/Firefox, iOS/Chrome:
image

E2E Test Recording

DataDog Graph to Monitor

https://paypal-prod.datadoghq.com/dashboard/5ut-fm5-pu4/paypal-web-sdk?fromUser=false&refresh_mode=sliding&from_ts=1751407301386&to_ts=1752012101386&live=true

CAL Logs & Regex

Rollback Considerations

Are there any services dependent on this change?

  • Yes
  • No

@mnicpt mnicpt requested a review from a team as a code owner October 16, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant