Skip to content

feat: support button label for CA #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: support button label for CA #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bec2cbb
adds french lang CA pi4 message
danzhaaspaypal Sep 15, 2025
cb193f3
supports aria label
danzhaaspaypal Oct 17, 2025
23535f8
corrects CA paylater product type
danzhaaspaypal Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/funding/common.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export type FundingSourceConfig = {|
fundingEligibility: ?FundingEligibilityType,
label?: string,
period?: number,
locale?: LocaleType,
|}) => string),
showWalletMenu: ({|
instrument: WalletInstrument,
Expand Down
27 changes: 21 additions & 6 deletions src/funding/paylater/config.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/** @jsx node */

import type { FundingEligibilityType } from "@paypal/sdk-client/src";
import { FUNDING } from "@paypal/sdk-constants/src";
import { FUNDING, type LocaleType } from "@paypal/sdk-constants/src";
import { node, Style } from "@krakenjs/jsx-pragmatic/src";
import {
PPLogoExternalImage,
Expand All @@ -21,9 +21,11 @@ import css from "./style.scoped.scss";

function getLabelText(
fundingEligibility: FundingEligibilityType,
locale?: LocaleType,
shouldApplyRebrandedStyles?: boolean
): ?string {
const { paylater } = fundingEligibility;
const { lang } = locale || {};

let labelText;

Expand All @@ -48,6 +50,14 @@ function getLabelText(
labelText = "Paga in 3 rate";
}

if (
paylater?.products?.paylater?.eligible &&
paylater?.products?.paylater?.variant === "CA" &&
lang === "fr"
) {
labelText = "Payer en 4";
}

if (paylater?.products?.payIn4?.eligible) {
labelText = "Pay in 4";
}
Expand Down Expand Up @@ -99,7 +109,9 @@ export function getPaylaterConfig(): FundingSourceConfig {
) : (
<PPLogoInlineSVG logoColor={logoColor} />
)}
<Text>{getLabelText(fundingEligibility) || "Pay Later"}</Text>
<Text>
{getLabelText(fundingEligibility, locale) || "Pay Later"}
</Text>
</Style>
);
}
Expand All @@ -120,8 +132,11 @@ export function getPaylaterConfig(): FundingSourceConfig {
<PPRebrandLogoInlineSVG logoColor={logoColorPP} />
)}
<Text>
{getLabelText(fundingEligibility, shouldApplyRebrandedStyles) ||
"Pay Later"}
{getLabelText(
fundingEligibility,
locale,
shouldApplyRebrandedStyles
) || "Pay Later"}
</Text>
</Style>
);
Expand Down Expand Up @@ -167,9 +182,9 @@ export function getPaylaterConfig(): FundingSourceConfig {
[BUTTON_COLOR.REBRAND_BLACK]: LOGO_COLOR.WHITE,
},

labelText: ({ fundingEligibility }) => {
labelText: ({ fundingEligibility, locale }) => {
return (
(fundingEligibility && getLabelText(fundingEligibility)) ||
(fundingEligibility && getLabelText(fundingEligibility, locale)) ||
`${FUNDING.PAYPAL} ${FUNDING.PAYLATER}`
);
},
Expand Down
1 change: 1 addition & 0 deletions src/ui/buttons/button.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ export function Button({
fundingEligibility,
label: eligibleLabel,
period,
locale,
})
: fundingConfig.labelText || fundingSource;

Expand Down