add eligibility check to children card fields in order to throw meaningful error messages #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusveloso
force-pushed
the
fix/card-fields-not-eligible-message
branch
from
4c48241 to
2ae6263
Compare
nikrom17
reviewed
Oct 24, 2025
src/zoid/card-fields/component.jsx
Outdated
| eligible: ({ props }) => { | ||
| // Prevent child field from being eligible if parent is not eligible | ||
| // Parent props will be empty as eligibility is checked before props are set | ||
| if (Object.keys(props.parent.props).length === 0) { |
There was a problem hiding this comment.
Lets add some some optional chaining checks in props.parent.lenghts just incase something is not defined.
…meaningful error messages when card fields aren't eligible
gusveloso
force-pushed
the
fix/card-fields-not-eligible-message
branch
from
2ae6263 to
96db6c6
Compare
nikrom17
approved these changes
Oct 24, 2025
delbarrow
approved these changes
Oct 28, 2025
jtanya17
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add eligibility check to children card fields in order to throw meaningful error messages error messages when card fields aren't eligible.
Before this change, only the parent card fields component had a eligibility check, but its children are rendered nonetheless, and they were throwing a not actionable error, without giving the information that it wasn't eligible.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Right now this is the error message thrown by a child card field component (cvv, number, name, expiry):
Uncaught Error: Expected prop "clientID" to be defined.We want to make it clearer:
Uncaught Error: card payments are not eligibleReproduction Steps (if applicable)
Uncaught Error: card payments are not eligiblefor each card fieldScreenshots (if applicable)
Groups who should review (if applicable)
❤️ Thank you!