Skip to content

fix: notify WindowHistoryAdapter when the page's URL is updated #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: notify WindowHistoryAdapter when the page's URL is updated #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions packages/use-query-params-adapter-window/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
import { useState } from 'react';
import { PartialLocation, QueryParamAdapterComponent } from 'use-query-params';
import { useEffect, useState } from 'react';
import {
PartialLocation,
QueryParamAdapterComponent,
QueryParamAdapter,
} from 'use-query-params';

function makeAdapter() {
function makeAdapter({ onChange }: { onChange(): void }): QueryParamAdapter {
const adapter = {
replace(location: PartialLocation) {
window.history.replaceState(location.state, '', location.search || '?');
onChange();
},
push(location: PartialLocation) {
window.history.pushState(location.state, '', location.search || '?');
onChange();
},
get location() {
return window.location;
Expand All @@ -24,8 +30,17 @@ function makeAdapter() {
export const WindowHistoryAdapter: QueryParamAdapterComponent = ({
children,
}) => {
const handleURLChange = () =>
setAdapter(makeAdapter({ onChange: handleURLChange }));
// we use a lazy caching solution to prevent #46 from happening
const [adapter] = useState(makeAdapter);
const [adapter, setAdapter] = useState(() =>
makeAdapter({ onChange: handleURLChange })
);

useEffect(() => {
window.addEventListener('popstate', handleURLChange);
return () => window.removeEventListener('popstate', handleURLChange);
}, []);

return children(adapter);
};