docs(readme): simplify quick-start docs #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
approved these changes
Apr 3, 2020
Member
orangejulius
left a comment
orangejulius
left a comment
There was a problem hiding this comment.
Looks pretty simple and good to me 👍
| # configure docker to write files as your local user | ||
| # see: https://github.com/pelias/docker#variable-docker_user | ||
| # note: use 'gsed' instead of 'sed' on a Mac | ||
| sed -i '/DOCKER_USER/d' .env |
Member
There was a problem hiding this comment.
What would it take to write a command that works on both Mac and Linux?
Member
Author
There was a problem hiding this comment.
Probably a doctorate in computer wizardry from Hogwarts 😸
| # see: https://github.com/pelias/docker#variable-docker_user | ||
| # note: use 'gsed' instead of 'sed' on a Mac | ||
| sed -i '/DOCKER_USER/d' .env | ||
| echo "DOCKER_USER=$(id -u)" >> .env |
Member
There was a problem hiding this comment.
yeah, why didn't we do this before!? So simple and obvious
Member
There was a problem hiding this comment.
I guess the next step would be to make DOCKER_USER optional and have the scripts run id -u by default, thereby making the instructions even shorter.
I think that was the idea behind old work like #74, but it was a long time ago.
calpb
pushed a commit
to sorelle/docker
that referenced
this pull request
Mar 29, 2021
docs(readme): simplify quick-start docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding #185 I would propose this as a simple solution to avoid the whole
/dataand/codethingI tested this out and placing the data files in
./dataworks fine, it's also nice because it makes archiving the installation much easier 🎉While I was at it I changed the line about permissions because it's wasn't super clear.