Skip to content

Conversation

@jimmylevell
Copy link
Contributor

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
For a project within Austria we are planning to set up our own pelisa server. The service will be running in a docker image.
Therefore this existing project needed to be extended to only download the regional data important for Austria.

Just let me know if I have to add anything more to fulfill your requirements.


Here's the reason for this change 🚀

I have extended the project for the country Austria.
This enables people to build pelias only for Austria which lowers the computational requirements for hosting their own instance of pelisa.


Here's what actually got changed 👏

  • changed the pelias.jsonto download the opendata required for Austria
  • provided example test link

Here's how others can test the changes 👀

  • pull the project and execute the Austrian definition
  • execute example URL

Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks, couple of small changes need to be made before merging.

@@ -0,0 +1,3 @@
COMPOSE_PROJECT_NAME=pelias
DATA_DIR=./data
DOCKER_USER=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will shortly merge #220 which will prevent users running as root.

This value should either be set as the default for other projects (1000) or removed if merged after #220

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your quick review. As requested I have updated the docker_user to 1000.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry to be a pain but could you please remove that line 🙏
We merged #220 already and I've removed it from the other projects already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry misunderstanding. Of course. As requested I have removed the line.

@missinglink missinglink merged commit 982fd2e into pelias:master Oct 16, 2020
@missinglink
Copy link
Member

Thanks!

@@ -1,2 +1,3 @@
COMPOSE_PROJECT_NAME=pelias
DATA_DIR=/tmp/pelias/portland-metro
DOCKER_USER=1000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I missed this in review, fixed in #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants