-
-
Notifications
You must be signed in to change notification settings - Fork 258
Added project for the country austria #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
missinglink
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks, couple of small changes need to be made before merging.
projects/austria/.env
Outdated
| @@ -0,0 +1,3 @@ | |||
| COMPOSE_PROJECT_NAME=pelias | |||
| DATA_DIR=./data | |||
| DOCKER_USER=0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your quick review. As requested I have updated the docker_user to 1000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry to be a pain but could you please remove that line 🙏
We merged #220 already and I've removed it from the other projects already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry misunderstanding. Of course. As requested I have removed the line.
|
Thanks! |
| @@ -1,2 +1,3 @@ | |||
| COMPOSE_PROJECT_NAME=pelias | |||
| DATA_DIR=/tmp/pelias/portland-metro | |||
| DOCKER_USER=1000 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops I missed this in review, fixed in #224
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
For a project within Austria we are planning to set up our own pelisa server. The service will be running in a docker image.
Therefore this existing project needed to be extended to only download the regional data important for Austria.
Just let me know if I have to add anything more to fulfill your requirements.
Here's the reason for this change 🚀
I have extended the project for the country Austria.
This enables people to build pelias only for Austria which lowers the computational requirements for hosting their own instance of pelisa.
Here's what actually got changed 👏
Here's how others can test the changes 👀